Skip to content

gh-102500: Implement PEP 688 #102521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JelleZijlstra merged 51 commits into from
May 4, 2023
Merged

gh-102500: Implement PEP 688 #102521

JelleZijlstra merged 51 commits into from
May 4, 2023

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Mar 8, 2023 •
edited
Loading

This PR implements only the code changes for the PEP; documentation will be added separately.

Example:

>>> memoryview(b"x", flags=inspect.BufferFlags.WRITABLE)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
BufferError: Object is not writable.
>>> memoryview(b"x", flags=inspect.BufferFlags.SIMPLE)
<memory at 0x103391640>

@JelleZijlstra
try 1
ca76251
@JelleZijlstra
progress
901b459
@JelleZijlstra
this is better
c5407c7
@JelleZijlstra
this seems to work
86f2000
@JelleZijlstra
one more test
ac10887
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
2563016
@JelleZijlstra
additions
530a160
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
de3a4bc
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
116f72e
@JelleZijlstra
introduce __mutable_buffer__ (rather hackily)
207d2fd
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
aee2c33
@JelleZijlstra
Rip out __mutable_buffer__
007fdc1
@JelleZijlstra
__release_buffer__ calls mv.release()
46a9239
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
3020fee
@JelleZijlstra
additional test
be9bf45
@JelleZijlstra
undo stray change
a6bf0e8
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
04d267e
@JelleZijlstra
throw an error if already released
04d0a42
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into pep688v2
bb6d076
@JelleZijlstra
Fix compiler warning
5f755fe
@JelleZijlstra
news
0b02e63
@JelleZijlstra JelleZijlstra requested a review from encukou March 8, 2023 01:37
@bedevere-bot bedevere-bot mentioned this pull request Mar 8, 2023
Closed
sobolevn
sobolevn reviewed Mar 8, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always happy when typing-related work is used for better APIs! Thank you 🎉

@JelleZijlstra JelleZijlstra requested a review from a team as a code owner March 10, 2023 04:58
kumaraditya303
kumaraditya303 reviewed May 4, 2023
View reviewed changes
@kumaraditya303
Copy link
Contributor

kumaraditya303 commented May 4, 2023

@JelleZijlstra I pushed some fixes directly, hope you don't mind it. See my review comments, especially the one for typeobject.

kumaraditya303
kumaraditya303 requested changes May 4, 2023
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented May 4, 2023

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@JelleZijlstra
Copy link
Member Author

JelleZijlstra commented May 4, 2023

Thanks Kumar for the review and fixes!

I have made the requested changes; please review again.

@bedevere-bot
Copy link

bedevere-bot commented May 4, 2023

Thanks for making the requested changes!

@hauntsaninja, @kumaraditya303: please review the changes made to this pull request.

kumaraditya303
kumaraditya303 reviewed May 4, 2023
View reviewed changes
@JelleZijlstra
Copy link
Member Author

JelleZijlstra commented May 4, 2023

Seems like I need to run regen-all, doing that.

kumaraditya303
kumaraditya303 approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JelleZijlstra JelleZijlstra merged commit 04f6733 into python:main May 4, 2023
@JelleZijlstra JelleZijlstra deleted the pep688v2 branch May 4, 2023 14:59
sunmy2019
sunmy2019 reviewed Jun 4, 2023
View reviewed changes
@JelleZijlstra JelleZijlstra restored the pep688v2 branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently left review comments

@sobolevn sobolevn sobolevn left review comments

@sunmy2019 sunmy2019 sunmy2019 left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@encukou encukou Awaiting requested review from encukou

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

+1 more reviewer

@TeamSpen210 TeamSpen210 TeamSpen210 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@JelleZijlstra @rhettinger @arhadthedev @ericsnowcurrently @bedevere-bot @kumaraditya303 @sobolevn @TeamSpen210 @hauntsaninja @sunmy2019